Fix checking for access_token query parameter #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
May 19, 2020
anoadragon453
force-pushed
the
anoa/access_token_query_parameter
branch
from
2455674
to
4323c85
Compare
clokep
approved these changes
May 19, 2020
anoadragon453
added a commit
to tristanlins/sydent
that referenced
this pull request
Jun 11, 2020
…cker * 'master' of github.com:matrix-org/sydent: changelog: OpenID auth tokens -> access tokens 2.0.1 Add newsfile Raise IncorrectSessionTokenException instead of returning it Fix documentation for testing skipping the deletion of 3PID invite tokens Cleanup and document tests for 3PID invites Fix checking for access_token query parameter (matrix-org#294) Update pyproject.toml Fix project name in pyproject.toml Add towncrier config Do a deep copy of the config default when parsing a dict Add test cases for invite deletion Add a config option to disable deleting tokens on bind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in python3, Twisted's
request.argsis a dictionary with keys of typebytes, whereas in python2 the keys are of typestr.So, for now, since we're supporting both python2 and 3, check for both.