Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/generate-key: Convert to Python3 syntax. #349

Merged
merged 1 commit into from Jun 1, 2021

Conversation

sunweaver
Copy link
Contributor

@sunweaver sunweaver commented Jun 1, 2021

Signed-off-by: Mike Gabriel mike.gabriel@das-netzwerkteam.de

Pull Request Checklist

  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fix a bug that prevented receiving messages from other servers." instead of "Move X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off

Signed-off-by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
@callahad
Copy link
Contributor

callahad commented Jun 1, 2021

Looks great at first glance -- will formally review this (and your other PRs; thank you!) later tonight

@sunweaver
Copy link
Contributor Author

sunweaver commented Jun 1, 2021 via email

Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :)

@callahad callahad merged commit 858cebe into matrix-org:main Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants