Convert http/servlets/registerservlet.py to use async/await #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts a function in http/servlets/registerservlet.py to use async/await. A few other files/functions needed to be changed as well.
One note: on
line 109
ofhttp/servlets/registerservlet.py
, I removed the keywordyield
from the call toissueToken
because when I substitutedawait
there, a few of the tests failed. After adding a breakpoint, I discovered that the call torenderPost
was failing with the following message:twisted.python.failure.Failure builtins.TypeError: object str can't be used in 'await' expression
. Mypy had also flagged this as a problem. I checked the function definition ofissueToken
and as far as I can tell it is not an asynchronous function so I am unclear as to why is was ever yielded to/awaited in the first place. Removing theawait
resulted in the tests all passing, so perhaps it was the right thing to do?