V2 of asyncjsonwrap #373
Merged
V2 of asyncjsonwrap #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H.Shay <shaysquared@gmail.com>
|
@H-Shay Looks like this has some conflicts due to merging the other branch! |
clokep
suggested changes
Jun 25, 2021
Signed-off-by: H.Shay <shaysquared@gmail.com>
clokep
reviewed
Jun 25, 2021
clokep
approved these changes
Jun 29, 2021
sydent/http/servlets/__init__.py
Outdated
|
|
||
| :param f: The original function passed to the asyncjsonwrap decorator |
There was a problem hiding this comment.
f isn't a parameter to inner, so I think we should leave it out from here!
There was a problem hiding this comment.
Right it's a param to render. I wasn't paying attention there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the second version of
asyncjsonwrap, based on the code skeleton you gave me. I did not add a changelog to this one because I figured only one of these PRs would be merged, so I'd add the proper changelog file to whichever version is the final one. The jury is out on which version is more readable/cleaner...