Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

black, flake8, etc shouldn't be in install_requires #389

Closed
richvdh opened this issue Sep 9, 2021 · 1 comment · Fixed by #390
Closed

black, flake8, etc shouldn't be in install_requires #389

richvdh opened this issue Sep 9, 2021 · 1 comment · Fixed by #390

Comments

@richvdh
Copy link
Member

richvdh commented Sep 9, 2021

setup.py lists some development tools under install_requires, but these aren't required to use the application, so shouldn't really be listed there.

One solution would be to define a dev 'extra' under extras_require.
@H-Shay H-Shay mentioned this issue Sep 9, 2021
Merged
@H-Shay
Copy link
Contributor

H-Shay commented Sep 9, 2021 •
edited

My bad! I opened a PR that will hopefully fix this.

@richvdh richvdh linked a pull request Sep 9, 2021 that will close this issue
Fix setup.py #390
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setup.py H-Shay/sydent
2 participants
@richvdh @H-Shay