Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start the prometheus server in run #391

Merged
merged 3 commits into from Sep 10, 2021
Merged

Start the prometheus server in run #391

merged 3 commits into from Sep 10, 2021

Conversation

babolivier
Copy link
Contributor

Otherwise scripts like the email migration one can't run while Sydent is running

@babolivier babolivier requested a review from a team September 10, 2021 09:44
anoadragon453
anoadragon453 approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't appear that the prometheus client would need to start in __init__ for any reason, so I think this is fine.

changelog.d/391.bugfix Outdated Show resolved Hide resolved
@babolivier @anoadragon453
Update changelog.d/391.bugfix
3f9ee33 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@babolivier babolivier merged commit 94ed7c1 into main Sep 10, 2021
@babolivier babolivier deleted the babolivier/prometheus branch September 10, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@babolivier @anoadragon453