Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run background deletion job in run #394

Merged
merged 3 commits into from Sep 13, 2021
Merged

Run background deletion job in run #394

merged 3 commits into from Sep 13, 2021

Conversation

babolivier
Copy link
Contributor

Rather than __init__, because we don't want this running eg when we run scripts or unit tests.

Also moved the gc hack to condition it to sentry being init'd since it makes more sense that way. Do we still actually need this workaround since getsentry/sentry-python#803 looks to have been fixed?

@babolivier babolivier requested a review from a team September 13, 2021 10:10
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minded to keep the Sentry hack around until we know for sure that the issue is gone (it was a very hard to diagnose issue)

@babolivier babolivier merged commit e8d5290 into main Sep 13, 2021
@babolivier babolivier deleted the babolivier/bg_job_run branch September 13, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants