Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger.exception in asyncjsonwrap #455

Merged
merged 2 commits into from Nov 3, 2021

Conversation

DMRobertson
Copy link
Contributor

instead of logger.error. This should hopefully give us a more
meaningful report in sentry (rather than a truncated traceback).

Will help with #452.

instead of `logger.error`. This should hopefully give us a more
meaningful report in sentry (rather than a truncated traceback).

Will help with #452.
@DMRobertson DMRobertson requested a review from a team as a code owner November 3, 2021 13:40
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@DMRobertson DMRobertson merged commit 92ff7a8 into main Nov 3, 2021
@DMRobertson DMRobertson deleted the dmr/sentry/exception-not-error branch November 3, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants