Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email validator incorrectly handling sendAttempt #460

Closed
DMRobertson opened this issue Nov 7, 2021 · 0 comments · Fixed by #461
Closed

Email validator incorrectly handling sendAttempt #460

DMRobertson opened this issue Nov 7, 2021 · 0 comments · Fixed by #461
Assignees
@DMRobertson
Labels
T-Defect

Comments

@DMRobertson
Copy link
Contributor

Introduced in 57ba780

The annotation for sendAttempt is incorrect. It is a str. Mypy cannot spot this because it is fed something of type Any GRRRRRR.

https://sentry.matrix.org/sentry/sydent/issues/234999/?query=is%3Aunresolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DMRobertson DMRobertson

Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert send_attempt to an int again matrix-org/sydent
1 participant
@DMRobertson