Fix CI by fixing the type errors for PyNaCl #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
reviewed
Jan 17, 2022
sydent/config/crypto.py
Outdated
| @@ -46,7 +53,7 @@ def parse_config(self, cfg: "ConfigParser") -> bool: | |||
| print("INFO: Updating signing key format: brace yourselves") | |||
|
|
|||
| self.signing_key = nacl.signing.SigningKey( | |||
| signing_key_str, encoder=nacl.encoding.HexEncoder | |||
| signing_key_str.encode(), encoder=nacl.encoding.HexEncoder | |||
There was a problem hiding this comment.
I wonder if this ought to be encode("ascii") so it doesn't fail silently if we give it something exotic?
There was a problem hiding this comment.
Sounds fair enough. I don't think it makes sense to put full-fat Unicode into your key.
There was a problem hiding this comment.
FWIW I found this encoder=... stuff to be fiddley when I was annotating this. But AFAICS they're all meant to take bytes and return bytes. Besides, I think pynacl might want to get rid of them anyway: pyca/pynacl#504 (comment)
|
Needs a quick linter script, I think. But mypy is happy, thanks! |
DMRobertson
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.