Fix bug in the casefolding script that would cause some deletions to be skipped if e-mail sending was enabled. #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… e-mails is disabled
…pping e-mail addresses
babolivier
reviewed
Jan 27, 2022
babolivier
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Thanks for bearing with me here. As a nitpick I'd say that it'd be nice if we logged deletion even if dry_run is true, so whoever runs it has a good idea of what should be happening outside of a dry run, but I'm not going to block the PR on that since it was already the case before this change.
|
That's fair, but generally this was only really useful for tracking down the bug. There's already INFO-level logging that tells you how many rows would be deleted, so all in all I'm not too worried about it. |
|
Fair enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also have updated a test case to cover this (verified that the test fails originally).
Also have moved the logging to occur before dangerous operations -- but the logging was still extremely useful in the end.