Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sydent could give more helpful warnings if the Host header doesn't match the configured value #513

Open
reivilibre opened this issue Mar 22, 2022 · 0 comments

Comments

@reivilibre
Copy link
Contributor

Right now, if Sydent is contacted by a homeserver as sydent.xyz.xyz but Sydent is configured as xyz.xyz, the request will fail by complaining about a corrupt or forged signature (SignatureVerifyException). It's fairly obscure.
This could be a lot better reported by making use of the HTTP Host header and detecting when that doesn't match what we expect.

Would have spotted #512 much more easily.

Potential problem: reverse proxies may not set the Host header by default. We could ameliorate this by providing example Nginx/... config that sets it, or warning if it's not present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant