Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a backpressure when sending peer messages to the conference #120

Open
daniel-abramov opened this issue Feb 1, 2023 · 0 comments
Assignees
Labels

Comments

@daniel-abramov
Copy link
Contributor

Currently, we use buffered channels with quite a larger buffer when we're sending messages from the peer to the conference to mutate the state of a conference. We do the same when we send incoming To-Device messages to the conference.

These queues don't seem to be very useful in most cases. It seems it's OK to let the senders block if the conference can't keep up with the messages as it would introduce a natural backpressure mechanism (i.e. it does not make sense to fill up the queue with the messages that must not even be necessary). It seems to play better with an idiomatic Go.

@daniel-abramov daniel-abramov added T-Enhancement New feature or request T-Task labels Feb 1, 2023
@daniel-abramov daniel-abramov self-assigned this Feb 1, 2023
@daniel-abramov daniel-abramov changed the title Introduce a backpressure when sending the messages to the conference Introduce a backpressure when sending peer messages to the conference Feb 15, 2023
@daniel-abramov daniel-abramov removed the T-Enhancement New feature or request label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant