fix: set cnset status replicas to cloneset ready replicas #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aylei
reviewed
Sep 19, 2023
pkg/controllers/cnset/controller.go
Outdated
| @@ -118,7 +118,7 @@ func (c *Actor) Observe(ctx *recon.Context[*v1alpha1.CNSet]) (recon.Action[*v1al | |||
| }) | |||
| } | |||
| cn.Status.Stores = stores | |||
| cn.Status.Replicas = cs.Status.Replicas | |||
| cn.Status.Replicas = cs.Status.ReadyReplicas | |||
There was a problem hiding this comment.
we need add a ReadyReplicas field since Replicas is for autoscaler
loveRhythm1990
force-pushed
the
cnstatus
branch
from
f14a3b6
to
4bfd024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes # https://github.com/matrixorigin/MO-Cloud/issues/1321
What this PR does / why we need it:
only when cn pod ready, the cluster
readycondition should be trueSpecial notes for your reviewer:
There are two ways to fix this probelm:
cn.status.replicasmean the ready replicas, not the total replicas, that is what this pr does. also inunit-agent, fieldcn.status.replicasmeans the ready replicas.cn.status.readyReplicasfield to indicate ready replicasAdditional documentation (e.g. design docs, usage docs, etc.):
in openkruise cloneset the field
cs.Status.Replicasmeans the total replicas