Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.2.0-alpha.3 #503

Merged
merged 1 commit into from
May 28, 2024
Merged

release 1.2.0-alpha.3 #503

merged 1 commit into from
May 28, 2024

Conversation

loveRhythm1990
Copy link
Contributor

@loveRhythm1990 loveRhythm1990 commented May 28, 2024

User description

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

Fixes : release operator for issue mocloud #3317

support update pvc when cloneset rolling update

What this PR does / why we need it:

Not Available

Special notes for your reviewer:

Not Available

Additional documentation (e.g. design docs, usage docs, etc.):

Not Available


PR Type

enhancement, configuration changes


Description

  • Updated the version field in Chart.yaml from 1.2.0-alpha.2 to 1.2.0-alpha.3.
  • Updated the image tag in values.yaml from 1.2.0-alpha.2 to 1.2.0-alpha.3.

Changes walkthrough 📝

Relevant files
Configuration changes
Chart.yaml
Bump chart version to 1.2.0-alpha.3                                           

charts/matrixone-operator/Chart.yaml

  • Updated the version field from 1.2.0-alpha.2 to 1.2.0-alpha.3.
  • +1/-1     
    values.yaml
    Update image tag to 1.2.0-alpha.3                                               

    charts/matrixone-operator/values.yaml

    • Updated the image tag from 1.2.0-alpha.2 to 1.2.0-alpha.3.
    +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    1, because the changes are minimal and straightforward, involving only version updates in two YAML files.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    No

    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Add a digest field for the image to ensure consistent deployments

    Consider adding a digest field for the image to ensure that the exact image version is
    used, which can help in achieving more consistent deployments.

    charts/matrixone-operator/values.yaml [12]

     tag: "1.2.0-alpha.3"
    +digest: "sha256:<your-image-digest>"
     
    Suggestion importance[1-10]: 7

    Why: Adding a digest field is a good practice for ensuring the exact version of the image is used, which enhances deployment consistency. The suggestion is relevant to the image tag update in the PR.

    7

    Copy link
    Contributor

    @aylei aylei left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm

    @aylei aylei merged commit 58c9660 into matrixorigin:main May 28, 2024
    3 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants