Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] txn client: fix hang issue. #12777

Merged
merged 2 commits into from Nov 16, 2023

Conversation

volgariver6
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue https://github.com/matrixorigin/MO-Cloud/issues/1733

What this PR does / why we need it:

some sequence bug results to the hang issue, fix:

  1. timestamp waiter and single txn waiter share the same channel
  2. add lock for the cancel channel. If pause the timestamp waiter,
    set the cancel channel to nil in timestamp waiter. If some new txns
    comes, refuse its creation because the channel is nil. After rollback
    all txns, resume the timestamp waiter and create a new cancel channel.

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Nov 16, 2023
@mergify mergify bot added the kind/bug Something isn't working label Nov 16, 2023
@sukki37 sukki37 merged commit db82683 into matrixorigin:1.0-dev Nov 16, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants