Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug that cause funtion convert_tz bad performance #14362

Merged
merged 5 commits into from
Jan 25, 2024
Merged

fix a bug that cause funtion convert_tz bad performance #14362

merged 5 commits into from
Jan 25, 2024

Conversation

badboynt1
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #14359

What this PR does / why we need it:

for constant parameter, do not need to calculate every time

@mergify mergify bot requested a review from sukki37 January 25, 2024 02:06
@mergify mergify bot added the kind/bug Something isn't working label Jan 25, 2024
@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Jan 25, 2024
@badboynt1 badboynt1 mentioned this pull request Jan 25, 2024
Merged
7 tasks
@sukki37 sukki37 merged commit 35aff9f into matrixorigin:1.1-dev Jan 25, 2024
15 of 16 checks passed
@badboynt1 badboynt1 deleted the converttz1.1 branch January 25, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-schen m-schen m-schen approved these changes

@sukki37 sukki37 Awaiting requested review from sukki37

Assignees
No one assigned
Labels
kind/bug Something isn't working size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@badboynt1 @m-schen @sukki37 @matrix-meow