Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: get incorrect result for "in" expr in some case #14602

Merged
merged 6 commits into from Feb 22, 2024

Conversation

ouyuanning
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue https://github.com/matrixorigin/MO-Cloud/issues/2533

What this PR does / why we need it:

fix bug: get incorrect result for "in" expr in some case.

bug case:

drop table if exists t1;
create table t1(a int primary key, b int);
insert into t1 values (1,1),(2,2),(3,3);
select mo_ctl('dn', 'flush', 'select.t1');
select * from t1 where a in (3,3,3,2,1);
-- here, we should get 3 rows. but 5 rows now

@mergify mergify bot added the kind/bug Something isn't working label Feb 20, 2024
@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Feb 20, 2024
@mergify mergify bot merged commit 862a18d into matrixorigin:main Feb 22, 2024
17 of 18 checks passed
ouyuanning added a commit to ouyuanning/matrixone that referenced this pull request Feb 22, 2024
…n#14602)

fix bug: get incorrect result for "in" expr  in some case.

bug case:
```sql
drop table if exists t1;
create table t1(a int primary key, b int);
insert into t1 values (1,1),(2,2),(3,3);
select mo_ctl('dn', 'flush', 'select.t1');
select * from t1 where a in (3,3,3,2,1);
-- here, we should get 3 rows. but 5 rows now
```

Approved by: @badboynt1, @XuPeng-SH, @nnsgmsone, @heni02, @aunjgr
ouyuanning added a commit to ouyuanning/matrixone that referenced this pull request Feb 22, 2024
…n#14602)

fix bug: get incorrect result for "in" expr  in some case.

bug case:
```sql
drop table if exists t1;
create table t1(a int primary key, b int);
insert into t1 values (1,1),(2,2),(3,3);
select mo_ctl('dn', 'flush', 'select.t1');
select * from t1 where a in (3,3,3,2,1);
-- here, we should get 3 rows. but 5 rows now
```

Approved by: @badboynt1, @XuPeng-SH, @nnsgmsone, @heni02, @aunjgr
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
@ouyuanning ouyuanning deleted the fix-in-filter-bug branch April 2, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants