sync to 1.1: restore the switched account id when mo_table_size and mo_table_rows. #14741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouhongshen
requested review from
nnsgmsone,
XuPeng-SH,
triump2020 and
m-schen
as code owners
7 tasks
XuPeng-SH
approved these changes
Mar 1, 2024
m-schen
approved these changes
Mar 1, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
…ws`. (#14740) consider this situation: ``` select dbName, count(*) as tblCnt, sum(tblSize) / (1024 * 1024.0) as db_size_in_mb from ( select reldatabase as dbName, mo_table_size(reldatabase, relname) as tblSize from mo_catalog.mo_tables left join mo_catalog.mo_database on reldatabase_id = dat_id where relkind in ('r', 'cluster', 'e') and mo_catalog.mo_tables.account_id = ( select current_account_id() as cur_acc_id) ) group by dbName order by db_size_in_mb; ``` if an SQL tries to gather all tables' sizes in one query, this will traverse all tables, including the cluster table, belongs this account. but if these tables in `tbls` has orders: xxx, cluster table, xxx, xxx, xxx, the account id stored in proc.Ctx will be changed to system account ID when processing that cluster table, causing the last three tables to not be found when calling the `engine.Database()`. so should be first to switch back to the right account ID when new round. cherry-pick to 1.1: #14741 Approved by: @XuPeng-SH, @m-schen
gouhongshen
added a commit
to gouhongshen/matrixone
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue ##13151
What this PR does / why we need it:
see ##14740 for details.