cherry pick "optimize plan for update with secondary index column (#14856)" to 1.1

[badboynt1]

change left join to right join and push down runtime filter

Approved by: @ouyuanning, @aunjgr

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue # https://github.com/matrixorigin/MO-Cloud/issues/2939

What this PR does / why we need it:

cherry pick "optimize plan for update with secondary index column (#14856)" to 1.1

[matrix-meow]

@badboynt1 Thanks for your contributions!

Pull Request Review:

Title:

The title of the pull request is clear and concise, indicating that a specific commit related to optimizing a plan for update with a secondary index column is being cherry-picked to version 1.1.

Body:

The body of the pull request provides context about the type of PR, the related issue, and the purpose of the changes. It also lists the approval from specific individuals. The information is relevant and helps in understanding the motivation behind the changes.

Changes:

1. Code Optimization:

   • The change from a left join to a right join in the appendDeleteUniqueTablePlan function is a significant optimization. This modification can improve query performance by changing the join type to better suit the query logic.
   • The addition of a new function getProjectionByLastNodeForRightJoin specifically tailored for right join scenarios enhances code readability and maintainability.

2. Security Concerns:

   • The use of runtime filters in the code raises potential security concerns. Runtime filters can be exploited for data leakage or injection attacks if not properly sanitized or validated. It is crucial to ensure that the runtime filter expressions are secure and do not expose sensitive information.

3. Code Clarity:

   • In some parts of the code, there are hardcoded values like RelPos: 0 and RelPos: 1. It would be beneficial to use constants or variables instead of hardcoded values to improve code clarity and maintainability.

4. Consistency:

   • There are inconsistencies in the use of variable names like orginIndexColumnName instead of originIndexColumnName. Maintaining consistent naming conventions throughout the codebase can enhance readability and reduce confusion.

Suggestions for Improvement:

1. Security Enhancement:

   • Validate and sanitize the runtime filter expressions to prevent any potential security vulnerabilities. Implement input validation and parameterized queries to mitigate the risk of SQL injection attacks.

2. Code Refactoring:

   • Consider refactoring the code to use constants or enums for hardcoded values to improve code maintainability and make future modifications easier.

3. Naming Consistency:

   • Ensure consistent naming conventions for variables and functions to enhance code readability and maintainability. Correct any typos or inconsistencies in variable names.

4. Code Review:

   • Conduct a thorough code review to identify any other areas where optimizations or security enhancements can be implemented. Collaborate with team members to ensure code quality and adherence to best practices.

By addressing the security concerns, enhancing code clarity, and maintaining consistency in naming conventions, the overall quality and security of the codebase can be improved. Additionally, continuous code reviews and collaboration among team members can help in identifying and resolving any potential issues in the future.