Dealing with side case in relation to text type. #7201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iceTTTT <329512443@qq.com>
iceTTTT
requested review from
aressu1985,
heni02,
ouyuanning and
aunjgr
as code owners
ouyuanning
approved these changes
Dec 15, 2022
ouyuanning
requested changes
Dec 15, 2022
ouyuanning
approved these changes
Dec 15, 2022
heni02
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue matrixorigin/MO-Cloud#285
What this PR does / why we need it:
The check of a big/small(more than 23) string should not use type.Width, and I use whether " area == nil" instead.
The width of text is 0, as a sign of unlimited upper bound, And when compare with other string type, the result should
be like the width of text is always bigger.