Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug; Flask v1.1.2 fails with MATRX visualization #179

Closed
jwaa opened this issue Jun 16, 2020 · 2 comments
Closed

Potential bug; Flask v1.1.2 fails with MATRX visualization #179

jwaa opened this issue Jun 16, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jwaa
Copy link
Member

jwaa commented Jun 16, 2020

Describe the bug
See this report at the AIMS project. It describes a connection failure between the JS server-client and their custom visualization Flask server.

To Reproduce
Should be test if this same bug applies to the MATRX Visualizer.

Expected behavior
Correctly loading of the pages, due to a succesful connection between the visualization server and the JS server-client.

Screenshots
If it fails you see this on localhost:3000
afbeelding

Stacktrace
A stacktrace can be viewed in your browser's console.

Additional context
The issue might be due to a combination of how MATRX uses Flask and the Flask v1.1.2 patch. However, this seems unlikely as the visualization_server.py is a very simple Flask server. Furthermore, the Flask issue list does not show an apparent report of such an issue, this combined with the relative few patch release of Flask (about once or twice a year), it is unlikely that this issue will be fixed soon.

A simple solution for us would be to fix the dependency of Flask to v1.1.1 and ignore these bug fixes. But only if MATRX suffers the same bug, if not it is a bug in the custom visualization of AIMS.

@jwaa jwaa added the bug Something isn't working label Jun 16, 2020
@jwaa jwaa added this to the Release v1.1.0 milestone Jun 16, 2020
@thaije
Copy link
Collaborator

thaije commented Jul 6, 2020

Flask can be finicky with file paths, and the Flask 1.1.2 patch seems to have changed something in the pointing to the static folder with static web files of our visualization web server. In AIMS this was solved by changing how the paths were defined, something which was already done in the newer versions of MATRX.

However, it is worth it to investigate if using the url_for() function can solve the issues with file paths forever, as used here.

Thus, there should be no problems with MATRX and Flask 1.1.2 itself. If someone still has this problem, please report it in this issue and I'll take another look.

@thaije thaije closed this as completed Jul 6, 2020
@thaije thaije self-assigned this Jul 6, 2020
@jwaa
Copy link
Member Author

jwaa commented Jul 6, 2020

In response to this bug in AIMS the Flask dependency for MATRX is now fixed to v1.1.1, I will set this back to =>v1.1.1 in a hotfix today.

jwaa added a commit that referenced this issue Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants