Additional features (refresh keyword, better parameter passing, terminal window bug fix)

[jcaille]

Hi !

I'm really interested in this project, and have added a few features that I needed for a few scripts

Refresh keyword

Adding the keyword refresh after the | adds an action to the menu item. Upon clicking this button, the plugin will be refreshed immediately.

Better parameter passing

The logic for parsing the parameter string felt a bit weak and prevented passing path containing spaces (or including small bash scripts inline)

I've refactored the way parameters are scanned using an NSScanner, which should be a bit more legible and robust. The legacy behaviour is kept, but this kind of lines are now possible

Say something | bash="say Hello world"
Say something else | bash:'say Goodbye moon;exit' terminal=true

Terminal window management

Launching a bash script by clicking a button failed when the frontmost terminal window was already running. I've changed the AppleScript to make sure to run the script in a new terminal window if terminal=true.
We might also include a keyword to close this window if the script returned a no error (0) status code

Let me know if you'd prefer multiple pull request

[matryer]

Multiple PRs would be great - I need to better understand some of what you've done. That ok?

[matryer]

Would you be interested in contributing to the project? I am considering a Swift rewrite.

[jcaille]

No problems at all !

I'll do that in the next few hours (and i'll make sure to update the
documentation as well.)

I'd love to contribute to the project. At the moment, i'm just adding features to match my needs.
Not very experienced with swift, but this might be a nice opportunity to learn

On 5 January 2016 at 11:27, Mat Ryer notifications@github.com wrote:

Multiple PRs would be great - I need to better understand some of what
you've done. That ok?

—
Reply to this email directly or view it on GitHub
#40 (comment).