Fix moq for go 1.13 and avoid creating empty directory

[pdrum]

This fixes #103 and also fixes #102

[ghost]

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

[pdrum]

packages.Load in golang.org/x/tools/go/packages fails in go 1.9.X and 1.10.X with an error like:

unsupported version of go: exit status 2: flag provided but not defined: -compiled

therefore I removed them from travis CI. Similar discussions can be found here and here.

I added go 1.13 to travis too.

[pdrum]

By the way the reason for failure with go 1.13 was very similar to the reason empty directories were created. pkgPath was inferred incorrectly. I made a repo illustrating the issue with go 1.13.

For the scenario given in the repo, second call to pkgInfoFromPath in New function of moq.go failed with the message:

Couldn't load mock package: go [list -e -json -compiled -test=false -export=false -deps=false -find=true --]: exit status 1: build .: cannot find module for path .

The reason why this happened is that in second call to pkgInfoFromPath, src had a value of ../foo/mocks, the folder was just created (the bug regarding creation of empty directory) and therefore empty. this call caused the error.

My solution is to

• Never create the empty directory.
• If the directory in which the command is executed is a valid go package and its name matches the name given as -pkg, that directory is set as pkgPath
• Else if the package in which the interface resides is the same as what is given as -pkg, that dir is considered as pkgPath
• Else if in the package containing the interface, there is a subdirectory with the same name as value of -pkg flag, that is set as the value of pkgPath
• Otherwise pkgPath is set to zero and packageQualifier never returns ""

I also did some refactoring to make New function simpler to understand

[pdrum]

@matryer @breml Will you consider taking a look at this please?

[thoeni]

LGTM 👍 - it'd be great to get this merged to unleash the full power of Go 1.13

[sudo-suhas]

Please note that it might be necessary to delete empty folders inside pkg/moq/testpackages/example for those who have the repo cloned prior to this merge.

[iamfortune]

So how do i fix this error cos i still get it on my VS code

[sudo-suhas]

Try updating the moq binary which is installed on your system.

$ go get -u github.com/matryer/moq

You might need to run this outside of a Go module project or add the GO11MODULE=off flag while running the command.