Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown file length or assertions limit? #41

Closed
rafavisa opened this issue May 17, 2016 · 9 comments
Closed

Markdown file length or assertions limit? #41

rafavisa opened this issue May 17, 2016 · 9 comments

Comments

@rafavisa
Copy link
Contributor

Is there any length limit for the .md file? Or any limitations in the number of asserts?

I am having some test failures due to .md parsing.
invalid request: net/http: invalid method "a@st"
** This is not what the .md files contains.

I can reproduce it by replicating a simple test that pass in the same file for several times. When I try to run exactly the same test for 6-7 times.

Any known issue?

Thanks

@antekresic
Copy link
Contributor

Take a look in issue #39, smells like the same issue.

@rafavisa
Copy link
Contributor Author

I've tried building last merge from today (3ebbb58) and I can reproduce the issue.

You can do it ie. by running a file that contains 15+ example tests like this one (https://github.com/matryer/silk/blob/master/examples/real/hello-api.silk.md)

The error in this case will be:
=== RUN silk
running 1 file(s)...
Get http://outlearn-hello.appspot.com a per
invalid request: parse http://outlearn-hello.appspot.com a per: invalid character " " in host name

@antekresic
Copy link
Contributor

I see. I wasn't able to reproduce your issue by using that example file. Any chance you can setup a gist with a Silk file and unit test that generates this issue? It would make it so much easier to check what is going on there.

Thanks.

@rafavisa
Copy link
Contributor Author

Can you reproduce it with https://gist.github.com/rafavisa/f2890eb897f6441aed9f746600854b67 ?

@antekresic
Copy link
Contributor

OK, I see the issue now. I'll take a look.

@rafavisa
Copy link
Contributor Author

Thank you!

@antekresic
Copy link
Contributor

Are you sure you are updating the code? I'm getting the same exact issue when using the code before the last merge and no issue after the merge (3ebbb58).

Can you try removing the repo from your GOPATH dir and doing go get github.com/matryer/silk?

@rafavisa
Copy link
Contributor Author

You are right, it is fixed now.

Thanks!

@antekresic
Copy link
Contributor

Awesome! Can you close this issue if its fixed?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants