Add a generic package manager plugin. #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Please host the image externally (imgur seems to be a popular choice.) This repo only contains scripts, not their screenshots or other ancillary data. |
|
@tresni : should I also convert my image to jpeg? Travis tests do not recognise PNG: https://travis-ci.org/matryer/bitbar-plugins/builds/142523996#L346 |
|
No, you need to remove it completely from your PR and host it externally (using your dot-files repo works, but I'd usually recommend an image hosting service such as imgur or imageshack.) |
|
@tresni : done. Also fixed a tiny issue about multiline description in metadata. |
|
👍 Going to start using this myself, nice work :) |
|
Thanks for the merge! That was fast! :) |
kdeldycke
added a commit
to kdeldycke/meta-package-manager
that referenced
this pull request
Aug 17, 2016
* Add a generic package manager plugin. * Tricks CI tests to workaround chicken and egg issue. * Host plugin image on imgur. * Metadata are not allowed on multiple lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supports Homebrew and Cask.
I plan to add others like Python's
pipin future revisions.