Dockerfile #364
Merged
Dockerfile #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @jgolob ! See how many commits are part of your PR? It'd be nicer if you'd rebase off of master (and then squash). Or, given that this is just one file, you can open a separate PR just adding the Dockerfile. |
|
As you've suggested, I've rebased off of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the dockerfile to also generate a docker container useful for using and building pplacer.
Built off the current master branch of the origin repo (to incorporate other changes to pplacer).
Directly loads file from repo rather than git pull.
Zips binaries into /pplacer.zip to ease update of binary distros.
Installs scripts into container environment.