-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linearham crashed #65
Comments
I haven't been able to reproduce this crash yet but it looks like it is crashing here: https://github.com/matsengrp/linearham/blob/master/src/VDJGermline.cpp#L51 i.e. the Thanks! |
I'm not sure how many similar null ptr checks are scattered around the linearham code, but it would be really nice if they could be replaced with error messages that give the user a better clue what's wrong. Something like throwing a runtime error with a message like "hmm_param_dir not found" would give the user a really good shot at fixing the problem themselves, since --hmm-param-dir is a something that was just passed in to linearham so they have some control over it, whereas asserting "dir" isn't null ptr sounds more like a coding error or memory issue than a dir not existing. I like this style of throwing things, although I wouldn't put the ERROR text these days since it's already getting kicked to std err. |
@scharch it seems like linearham is trying and failing to use
|
Yes, the directory exists; I copied the partis output there when I was having trouble specifying the command line options.
|
possible a spelling error? |
Awwwwww hell |
The text was updated successfully, but these errors were encountered: