Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve intermodal route only handling #2835

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

jfbischoff
Copy link
Collaborator

fixes #2802
In the SwissRailRaptorConfig, there is now a switch to define the desired behavior for handling routes, where feeder-Station-feeder legs return the lowest cost pt route:

  • forbid: These routes are discouraged, instead the router will try to find a route with at least one pt leg. If nothing is found, null is returned (= which later translates into the fallback mode, usually walk)
  • avoid: These routes are discouraged, instead the router will try to find a route with at least one pt leg. If nothing is found, the router will return a feeder-station-feeder leg
  • allow: These routes are allowed if they produce the lowest cost. This could be useful in combination with on-demand modes
  • returnNull (deprecated): This mimics the behavior that was currently produced. This behavior is basically "allow", followed by an overwriting of this route by null. If feeder modes are defined at very low cost, this can lead to very unwanted behavior.

forbid is currently the default. This should have the lowest impact on existing scenarios, yet still remove the buggy behavior that could have occured before.

@jfbischoff jfbischoff added the code sprint Possible issue(s) for the MATSim code sprint label Oct 11, 2023
@jfbischoff jfbischoff merged commit ea46da1 into master Oct 11, 2023
49 checks passed
@jfbischoff jfbischoff deleted the feature/improve-intermodal-only-route-handling branch October 11, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code sprint Possible issue(s) for the MATSim code sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant