Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default for usePersonIdForMissingVehicleId to false. #2885

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public enum EndtimeInterpretation {minOfEndtimeAndMobsimFinished, onlyUseEndtime
@Positive
private double stuckTime = 10;
private boolean removeStuckVehicles = false;
private boolean usePersonIdForMissingVehicleId = true;
private boolean usePersonIdForMissingVehicleId = false;
@Positive
private int numberOfThreads = 1;
// private static final String CREATING_VEHICLES_FOR_ALL_NETWORK_MODES = "creatingVehiclesForAllNetworkModes";
Expand Down Expand Up @@ -240,18 +240,18 @@ public final Map<String, String> getComments() {
public enum NodeTransition {
emptyBufferAfterBufferRandomDistribution_dontBlockNode,
emptyBufferAfterBufferRandomDistribution_nodeBlockedWhenSingleOutlinkFull,
moveVehByVehRandomDistribution_dontBlockNode,
moveVehByVehRandomDistribution_nodeBlockedWhenSingleOutlinkFull,
moveVehByVehRandomDistribution_dontBlockNode,
moveVehByVehRandomDistribution_nodeBlockedWhenSingleOutlinkFull,
moveVehByVehDeterministicPriorities_nodeBlockedWhenSingleOutlinkFull
/* note: moveVehByVehDeterministicPriorities is not implemented for the case when the node is not blocked
/* note: moveVehByVehDeterministicPriorities is not implemented for the case when the node is not blocked
* as soon as a single outlink is full
* theresa, jun'20
*/
}
private NodeTransition nodeTransitionLogic = NodeTransition.emptyBufferAfterBufferRandomDistribution_dontBlockNode;

// ---

public QSimConfigGroup() {
super(GROUP_NAME);
}
Expand Down Expand Up @@ -641,16 +641,16 @@ public boolean setUsingTravelTimeCheckInTeleportation( boolean val ) {
// yyyyyy this should better become a threshold number! kai, aug'16
return this.usingTravelTimeCheckInTeleportation = val ;
}

static final String PCU_THRESHOLD_FOR_FLOW_CAPACITY_EASING = //
"Flow capacity easing is activated for vehicles of size equal or smaller than the specified threshold. "
+ "Introduced to minimise the chances of buses being severely delayed in downsampled scenarios";


public double getPcuThresholdForFlowCapacityEasing() {
return pcuThresholdForFlowCapacityEasing;
}

/**
* @param pcuThresholdForFlowCapacityEasing -- {@value #PCU_THRESHOLD_FOR_FLOW_CAPACITY_EASING}
*/
Expand Down Expand Up @@ -685,5 +685,5 @@ public void setInflowCapacitySetting(InflowCapacitySetting inflowCapacitySetting
// // yyyy do we really need this switch? Quite in general, please try to avoid boolean switches. kai, may'18
// this.creatingVehiclesForAllNetworkModes = creatingVehiclesForAllNetworkModes;
// }

}