Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Runnable request without Promise #6

Merged
merged 3 commits into from
May 5, 2019
Merged

Implement Runnable request without Promise #6

merged 3 commits into from
May 5, 2019

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented May 4, 2019 •
edited
Loading

If Http().singleRequest was failing, the promise was never completed and the handler wasn't signaled with onError.

This lead to problems for some Alpakka users: See #1665

@matsluni
Copy link
Owner

matsluni commented May 5, 2019

@RustedBones thanks for your contribution. I will have a look at it right away.

matsluni
matsluni approved these changes May 5, 2019
View reviewed changes
Copy link
Owner

@matsluni matsluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except to the the comment about the headers this looks really good to me.

Thank you very much for this change and handling the error case correct. It were some really stupid mistakes from me. 🤦‍♂

@matsluni
Copy link
Owner

matsluni commented May 5, 2019

If the PR is merged I will do another release.

@matsluni
Copy link
Owner

matsluni commented May 5, 2019

@RustedBones thank you very much for your efforts and the PR! 💯

@matsluni matsluni merged commit f09cd92 into matsluni:master May 5, 2019
@matsluni matsluni mentioned this pull request May 16, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsluni matsluni matsluni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RustedBones @matsluni