Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

m-notched-outline not working with m-select #149

Closed
e-oj opened this issue Aug 14, 2018 · 9 comments
Closed

m-notched-outline not working with m-select #149

e-oj opened this issue Aug 14, 2018 · 9 comments
Assignees
Labels

Comments

@e-oj
Copy link

e-oj commented Aug 14, 2018

Great job with this library. I'm trying to use notched outline with the select component but it's not working.

To Reproduce
Steps to reproduce the behavior:

<m-select outlined v-model="address.city" id="city-settings">
   <option :key="'rochester'" :value="'Rochester'">Rochester</option>

   <m-floating-label slot="label">
     City
   </m-floating-label>

   <m-notched-outline slot="line"></m-notched-outline>
</m-select>

Expected behavior
Should behave like the outlined select example

Screenshots
Does this instead
screen shot 2018-08-14 at 8 27 13 pm

Any help would be appreciated

@matsp
Copy link
Owner

matsp commented Aug 14, 2018

Thanks for filling this issue.

The arrow issue could be resolved with postcss/autoprefixer or manual adding '-webkit-appearance: none;' to the CSS class.

You imported the notched-outline component correctly? Can you see it in the DOM?

@matsp matsp added the analysis label Aug 14, 2018
@matsp matsp self-assigned this Aug 14, 2018
@e-oj
Copy link
Author

e-oj commented Aug 14, 2018

I can't see it in the DOM. The notched outline component is imported correctly though; I'm using it successfully on textfields in the same form.

@matsp matsp added bug and removed analysis labels Aug 14, 2018
@matsp
Copy link
Owner

matsp commented Aug 14, 2018

At least the js instantion is missing. I have to investigate why it is working on the textfield.

@e-oj
Copy link
Author

e-oj commented Aug 14, 2018

JS imports
screen shot 2018-08-14 at 9 53 56 pm

Style Imports
screen shot 2018-08-14 at 9 55 25 pm

@matsp
Copy link
Owner

matsp commented Aug 14, 2018

I meant on the component side. Think your code is okay ;)

@e-oj
Copy link
Author

e-oj commented Aug 14, 2018

Oh. Alright.

@matsp
Copy link
Owner

matsp commented Aug 15, 2018

@e-oj
Can you upgrade to version 0.26.0 and have a look if it fixed your issue?

@e-oj
Copy link
Author

e-oj commented Aug 15, 2018

Yes it does. Thanks 👍 👍

@e-oj e-oj closed this as completed Aug 15, 2018
@matsp
Copy link
Owner

matsp commented Aug 15, 2018

Thanks for testing 👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants