Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

m-dialog not closing via v-model #376

Closed
gabrielbonner opened this issue Aug 6, 2019 · 0 comments · Fixed by #380
Closed

m-dialog not closing via v-model #376

gabrielbonner opened this issue Aug 6, 2019 · 0 comments · Fixed by #380
Assignees
@tychenjiajun

Comments

@gabrielbonner
Copy link

Describe the bug
m-dialog does not close when the v-model value is set to false. Apologies in advance if I'm missing something obvious.

To Reproduce
https://codesandbox.io/s/m-dialog-issue-oq200
Click on button that says "Click me"

Expected behavior
When "this.isDialogOpen" changes to false, I expect the dialog to close

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
https://codesandbox.io/s/m-dialog-issue-oq200
@tychenjiajun tychenjiajun self-assigned this Aug 7, 2019
tychenjiajun added a commit to tychenjiajun/material-components-vue that referenced this issue Aug 8, 2019
@tychenjiajun
fix(dialog): close via v-model
9d55aae 
fixes matsp#376

add documents
@tychenjiajun tychenjiajun mentioned this issue Aug 8, 2019
Merged
tychenjiajun added a commit that referenced this issue Aug 12, 2019
@tychenjiajun
fix(dialog): close via v-model (#380)
13895fc 
fixes #376

add documents
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tychenjiajun tychenjiajun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dialog): close via v-model tychenjiajun/material-components-vue
2 participants
@tychenjiajun @gabrielbonner