Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable specifying container name #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TMats
Copy link
Member

@TMats TMats commented Feb 10, 2021

We can specify container name

@TMats
Copy link
Member Author

TMats commented Feb 10, 2021

この変更どう思いますか....?本家にPR出してもいいのかな...

@Jumpei-Arima
Copy link
Contributor

container名を設定できるようにしたいのは,複数のrealsenseを起動したいからですかね?

そうだった場合は,このlaunch fileみたいにlaunch file側で複数起動する方が,同じ環境のdocker containerを複数起動より賢い気がします.

(独自のrs_multiple_diveces.launchを作ってそれをマウントして起動みたいな感じかな.)

@Jumpei-Arima
Copy link
Contributor

このPRの内容自体は,あってもいい機能なので,本家にPR投げてもらっても大丈夫です.

@TMats
Copy link
Member Author

TMats commented Feb 10, 2021 via email

@TMats
Copy link
Member Author

TMats commented Feb 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants