New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translatable #39
Translatable #39
Conversation
scottgrayson
commented
Sep 28, 2022
•
edited
edited
- require translatable package and updated requirements for php and db
- make attributes translatable for survey models
- add indexes to db tables
…-survey into translatable
Hi @scottgrayson and @andreia, thank you for using laravel-survey and for taking the time to create this PR. I think both spatie/eloquent-sortable and spatie/laravel-translatable are great choices you made in your work, but I'm cautious about adding them as new dependencies to this package, mostly because:
These make me think that it'd be better to leave it to users to install spatie/laravel-translatable directly in their app and extend laravel-survey models and override them as and when they need to. Leaving the PR open for discussion. |
…n_model Add sortable config on question model
Add section_id to question fillable fields