Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct if stop condition when downloading #14

Closed
matt-dray opened this issue Oct 6, 2022 · 0 comments · Fixed by #15
Closed

Correct if stop condition when downloading #14

matt-dray opened this issue Oct 6, 2022 · 0 comments · Fixed by #15
Labels
bug Something isn't working

Comments

@matt-dray
Copy link
Owner

The protocol argument check gets evaluated even when copy_type == "download" . It shouldn't. The !protocol %in% c("https", "ssh") in the if should only evaluate if copy_type == "clone" passes. So probably change & to && (preferred) or used nested ifs.

> ghdump::ghd_copy("co-analysis", "~/Desktop/co-analysis_copies", copy_type = "download")
Error in if (copy_type == "clone" & !protocol %in% c("https", "ssh")) { : 
  argument is of length zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant