Look at stack struct for local variables #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbanks
approved these changes
May 28, 2022
There was a problem hiding this comment.
It seems like the output changes are pretty small, so I'm good with adding this. (I don't feel super strongly about it though)
On Discord you mentioned:
maybe we should instead emit unkspXX for reads from unwritted/unaddressed stack locations
to show that something weird is probably up
-- I think this would be neat, but I don't know if it's worth adding? (It might not be worth the code)
| any_decl = True | ||
| stack_struct_fields = stack_struct_fields[::-1] | ||
| for field in stack_struct_fields: | ||
| type_decl = field.type.to_decl(field.name, fmt) |
There was a problem hiding this comment.
I think LocalVar.toplevel_decl(...) can be deleted now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing sp vars that were either only read from (due to being fake and actually part of structs that we fail to detect), or are structs/arrays which never ended up in local_vars because we only generated subfield accesses. Despite adding fake vars I think it's an improvement to have them in the output for the sake of coherence?
(Hard to give project diffs because of how separated declarations are from usages.)