Important Lich and Infomon Updates #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync with ML Master Lich
Update to Current Lich Master
Synch back to ML Lich Master
|
@OSXLich-Doug Nice, spacing looks off but otherwise change looks good and that should do it https://github.com/matt-lowe/Lich/pull/54/files#diff-1e33190934093d211db93ffbc0834f498d60b30470d5d259df53bac9b2d6ea80R11020 |
|
@coderintherye Thanks. Away from my system. Can the spacing be corrected after merge? Or do I need to kill this one and resubmit when I return? My bad - I thought you might be merging on behalf of Tillmen. Skip the question. If he doesn't get the merge in place soon, I'll redo. Thanks for the feedback! |
|
@OSXLich-Doug Yeah no I wouldn't hold it up for spacing, can always fix that later! |
Closed
|
Verified or added in GTK3 lich version 5.0.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes Infomon changes that affect ALL lich installs because of recent changes to SIMU output types (Commagedon and Combat Maneuver changes), and Lich changes that benefit ALL lich installs by adding the new combat maneuvers rolled out last month, and incorporate important changes to support Mac users. Details are as follows.
Infomon:
One change to fix infomon for Commagedon (critical all)
One change to account for changed text output from Simu on combat maneuvers released last month (critical all)
Lich (incremented to 4.6.59 with this PR):
Multiple line changes converting FIXNUM to INTEGER type (remove warnings, not critical)
Multiple line changes to add / remove combat maneuvers released last month (critical all)
Added AVALON capability to Quick Entry Tab for Mac Users (important Mac only)
Included a GTK function and a GTK function call which allows Mac users to benefit from Metal and current ruby / gems (critical Mac only for macOS 10.14-10.15)
The Lich changes incorporate an earlier pull request from Jan 3 (removed). The Lich changes do not include any specific changes in the master branch from other PRs. These changes are critical to improving user experience for our gamers.