Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test for singleton maps #10

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Conversation

prednaz
Copy link
Contributor

@prednaz prednaz commented Feb 18, 2020

The first test's result was ignored because the Monad instance for functions was used.

@@ -41,9 +41,9 @@ spec = do
it "wraps the underlying Data.Map.Map without modification" $ do
withMap letters theMap == letters

it "can create singleton maps" $ property $ do
\(k :: Int, v :: Int) -> withSingleton k v (uncurry lookup) == v
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first test's result is ignored. You could return False here and the test suite would pass.

@matt-noonan matt-noonan merged commit 38233a7 into matt-noonan:master Feb 20, 2020
@matt-noonan
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants