Setting verbose mode doesn't set the logger level do 'debug'

[karlitos]

Describe the bug
I searched for a way to detect, whether the -v/--verbose flag was set. My expectation was to look at the level attribute of the logger parameter in the action call.

To Reproduce
Steps to reproduce the behavior:

program.command('test', 'Just a test')
	.action((args, options, logger) => {
                 // is always 'info'
		console.log(logger.level)
	});
program.parse(process.argv);

Expected behavior
My expectation was, that running the cli with the -v/--verbose flag would set the level to debug

Environment informations (please complete the following information):

• OS: Mac
• Shell: bash
• Caporal version: 1.3.0

Additional context
If my suggestion was wrong, could you please tell me how to detect the -v/--verbose flag ?

[jhorbulyk]

It looks like the logging level is set on each of the loggers transports but not on the logger itself:

Caporal.js/lib/program.js

Lines 185 to 188 in db19813

	_changeLogLevel(level) {
	const logger = this.logger();
	Object.keys(logger.transports).forEach(t => logger.transports[t].level = level)
	}

[karlitos]

Many thanks for your reply. But I don't fully understand what does it mean regarding my intention to detect the global verbose settings. I realized I can get the debug/info flog from logger.transports.caporal.level, but is it a good/recommended way of doing it ?

[karlitos]

Hi, may I ask if there will be any further development regarding the setting the log level on the logger or whether I shall use logger.transports.caporal.level ?

[mattallty]

Hey there - I've released beta of the next Caporal (v2). The v2 is a full rewrite of Caporal in Typescript. This issue should be addressed in v2.

Be warned that, while most of the usage remain the same, the v2 is not backward compatible with v1.

You can test it with npm install @caporal/core@beta

• Docs are available here: https://beta.caporal.io
• You may want to be specifically interested in the migration guide located here: https://beta.caporal.io/guide/migration.html

Feel free to open issues regarding v2. I would also be happy if you have any feedbacks / suggestions.

[karlitos]

I can confirm, that v2 version solved my problem, I updated my project to use caporal v2 and so far - so good

[mattallty]

Great news - what is the v2 version you're using ?

[mattallty]

I'm planning to release a stable version for v2 - But I don't have a lot of feedbacks so far

[karlitos]

Great news - what is the v2 version you're using ?

"@caporal/core": "^2.0.0-beta.2",

[mattallty]

I've released a final version + some fixes over the week-end, you should be able to install @caporal/core@2.0.2

…

On Mon, Jun 15, 2020 at 3:19 PM Karel Mácha ***@***.***> wrote: Great news - what is the v2 version you're using ? ***@***.***/core": "^2.0.0-beta.2", — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#172 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABLTOBXNPXMOXVVRTTBKIDRWYNXVANCNFSM4MKVEOWA> .