Fix auto-completion #201
Closed
Fix auto-completion #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds test for auto completing command names when no partial name has been entered
adds test to ensure that the 'completion' command, which is invoked by tabtab, is handled
fixes test for completion of command names when no partial command name has been entered.
|
After getting into this, the changes required here are more significant than I imagined and are probably best made by @mattallty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#200
Auto completion appears to have been broken since v2.x was released since
Programdoesn't have any special handling for thecompletioncommand that the shell scripts invoke. Additionally, thecompletefunction doesn't handle the case of auto completing top level commands when no partial command has been entered.This PR will correct these issues, starting with tests that demonstrate the problems.