Adding compatibility with HoTT for 8.19 #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bit of porting involved, but not much.
Ideally, it would be nice to get this into opam, I guess it is only a matter of doing a release here + a PR on the coq/opam side. I can try to take care of the PR for opam if you don't have the cycles @mattam82, (that way, I'll learn a new skill), but in any case you'll have to do a release first, I guess?
Also, I only did the change for 8.19 because that's the version I was interested in, but I can also port this to other versions if there is interest (although I guess it can't go into main because coq-hott is not following Coq's master?).