Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squotable #1

Merged
merged 5 commits into from Feb 1, 2021
Merged

squotable #1

merged 5 commits into from Feb 1, 2021

Conversation

ethdmill
Copy link
Contributor

  • added squotable command
  • updated other files as necessary

Copy link
Owner

@mattbalmer mattbalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Some specific recommendations for naming & abstraction + one thought on command experience.

commands/hello.ts Show resolved Hide resolved
commands/most-squotable.ts Outdated Show resolved Hide resolved
commands/most-squotable.ts Outdated Show resolved Hide resolved
commands/most-squotable.ts Outdated Show resolved Hide resolved
commands/most-squotable.ts Outdated Show resolved Hide resolved
commands/most-squotable.ts Outdated Show resolved Hide resolved
commands/most-squotable.ts Outdated Show resolved Hide resolved
commands/most-squotable.ts Outdated Show resolved Hide resolved
utils/arrays.ts Outdated Show resolved Hide resolved
Copy link
Owner

@mattbalmer mattbalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this!

@mattbalmer mattbalmer merged commit 2357172 into mattbalmer:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants