-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location Hook Not Working as Expected #94
Comments
Hi Tim, I hope you’re doing fine. I’m reaching you to know if you solved this bug or if you have any solution to relocate the pickup time box ? After several tries of others plugins, yours is the best one so… 😀 |
@bantunesm I know this is well overdue, but I have determined why there might be problems with this. And actually, choosing the location of the Pickup Time is going to be deprecated as of the next release. In version 1.4.0 there will be an option to link the Pickup Time specifically to the Local Pickup shipping method, and this change moves the Pickup Time to be output along with the "Local Pickup" shipping method selection radio button. There is not a lot of flexibility with that as newer versions of WooCommerce have introduced and AJAX handling of the checkout totals that will refresh without a full page refresh. This will cause problems for users where the Pickup Time selection would need a large amount of custom code to manage that field along with a shipping change to update a whole different part of the page. It's possible that this feature could return in the future in a non-deprecated way but it will be low on the priority list. |
* Updates NPM & Composer dependencies. * Moves the plugins settings to WooCommerce->Settings->Shipping->Local Pickup Time settings. * Reformats some of the plugin settings display. * Adds new settings screenshots. * Removes checks that prevent loading the Admin class during AJAX calls. * Adds the ability to change whether the Pickup Time is required on checkout via a plugin setting. Closes WC-Local-Pickup#71 * Adds the ability to link Pickup Time to a Local Pickup Shipping Method. Closes WC-Local-Pickup#23 / Closes WC-Local-Pickup#94 * Changes output of Pickup Time selection. Closes WC-Local-Pickup#103 / Closed WC-Local-Pickup#104 * Changes the Pickup Time select field options to use a blank entry for the default upon load. Closes WC-Local-Pickup#123
* Updates NPM & Composer dependencies. * Moves the plugins settings to WooCommerce->Settings->Shipping->Local Pickup Time settings. * Reformats some of the plugin settings display. * Adds new settings screenshots. * Removes checks that prevent loading the Admin class during AJAX calls. * Adds the ability to change whether the Pickup Time is required on checkout via a plugin setting. Closes #71 * Adds the ability to link Pickup Time to a Local Pickup Shipping Method. Closes #23 / Closes #94 * Changes output of Pickup Time selection. Closes #103 / Closed #104 * Changes the Pickup Time select field options to use a blank entry for the default upon load. Closes #123
Describe the bug
I followed this https://wordpress.org/support/topic/can-you-give-an-example-of-how-to-change-the-location-of-the-pickup-time-box/ but somehow, the pickup time box is always in the default location.
Am I doing something wrong?
To Reproduce
Steps to reproduce the behavior:
Here is the code in functions.php
Expected behavior
The Local Pickup Time should output in the location specified by the hook.
Isolating the problem (mark completed items with an [x]):
WordPress Environment
References
The text was updated successfully, but these errors were encountered: