Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not equalize splits when not moving off screen #24

Closed
svermeulen opened this issue Oct 10, 2013 · 9 comments
Closed

Should not equalize splits when not moving off screen #24

svermeulen opened this issue Oct 10, 2013 · 9 comments

Comments

@svermeulen
Copy link

I tend to have two splits on screen and often will resize them using something like ":vertical resize -5". I find this reverts back to equalized windows when I move from one to the other. This behaviour makes sense when moving to a new (off screen) split, but I don't see why this is necessary when moving to the other split that is visible.

@mattboehm
Copy link
Owner

Good point, I'll work on a fix for this tonight.

@svermeulen
Copy link
Author

Awesome. I took a look but could not make heads or tails of it.

@svermeulen
Copy link
Author

Great, thanks! Not sure if this existed before or not, but I noticed that if I execute ':vsplit' now (after running :Accordion 2) that it keeps 3 splits open

@mattboehm
Copy link
Owner

That's probably a new behavior; I really need a set of automated tests to capture all possible window action combinations. Thanks for noticing. I've captured this in #25 and will address it sometime today.

@mattboehm
Copy link
Owner

Should be fixed now. The one caveat is that it also redraws after :sp I've opened #26 to capture this issue.

@svermeulen
Copy link
Author

Yep, fixed for me.

@svermeulen
Copy link
Author

Unrelated question: What is the recommended way to to make it always enabled? Hook into OnWinEnter? Add to mappings for new window/tab?

@svermeulen
Copy link
Author

Another suggestion: Zoom-out should max out at the number of windows. And zoom in should stop at 1 (right now t:accordion-size will go into negative values)

@mattboehm
Copy link
Owner

To always enable it, you would run :AccordionAll 3 once, perhaps in your vimrc.

I should limit the zoom in to 1 if I don't already but don't want to limit zoom out as you may want to set the limit to more than the current number of splits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants