New option: onBegin(). A custom event before it begins typing. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattboldt added the fiddle. Please review, I hope it helps. Thanks a lot. |
|
Thank you for the addition! However, it looks like you switched from 2 spaces of indentation to 4 spaces. Could you fix that first? |
|
@mattboldt Sorry about that. Can you please tell me how can I fix it? I have no idea at the moment about how indentation changed. I'm currently using VSCode and I don't have the 4 spaces issue, it is only showing 2 spaces. |
|
Just realized it’s in the compiled versions of the source. Must be something up with the gulp config?
… On May 27, 2018, at 4:02 AM, Seif Sgayer ***@***.***> wrote:
@mattboldt Sorry about that. Can you please tell me how can I fix it? I have no idea at the moment about how indentation changed. I'm currently using VSCode and I don't have the 4 spaces issue, it is only showing 2 spaces.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
is there any change to get this integrated? |
|
Moving to #429 due to conflicts/formatting issues |
|
Sorry for the delay, this is in the newest release! @marabesi @seifsg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Have you viewed your changes locally on the demos page, located on https://github.com/mattboldt/typed.js/blob/master/index.html?
If necessary, have you added a new demo to the index.html list of demos? If it's an improvement or small addition, have you added it to an existing demo on the demos page?
If applicable, have you created a fork of the following JSFiddle with your branch's code and your new feature showcased?
Here is the fiddle: https://jsfiddle.net/seifsg/gknstoff/
Description of the Change
I was working on my app and I needed to fire an event just right before it begins typing. I didn't find how so I added it the code. Works fine on my app now.
Also, I have added it to the documentation and the demo.
I hope it helps!
Benefits
New option: onBegin()
A custom function just before it begins typing
Issues
No issues yet.