Upgrade Prometheus library dependencies #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the latest version of the Prometheus libraries and make necessary changes to satisfy API changes: - Use NewMergeSeriesSet() instead of DeduplicateSeriesSet(), which was removed in prometheus/prometheus@bb724f1bef6a. - Explicitly specify the options for the PromQL engine to ensure that PromQL metrics are registered following the change in prometheus/prometheus@f8fccc73d8705. The options used here are copied from the defaults. Prometheus vendors its own dependencies but also provides library packages, meaning that we have to manage its dependencies as transient dependencies. Using the `dep` tool, we cannot manage transient dependencies using regular constraints so I had to pin the versions in `Gopkg.toml` using overrides. See: https://github.com/golang/dep/blob/master/docs/FAQ.md#how-do-i-constrain-a-transitive-dependencys-version golang/dep#999 (comment) golang/dep#302
Pass a logger to the PromQL library so that we can see its logs. Prior to 1fe1279 we were using the default options for PromQL, which meant that a no-op logger was being used.
mattbostock
force-pushed
the
update_deps_2
branch
from
7d2de6c
to
c1a6974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest version of the Prometheus libraries and make
necessary changes to satisfy API changes:
Use NewMergeSeriesSet() instead of DeduplicateSeriesSet(), which was
removed in prometheus/prometheus@bb724f1.
Explicitly specify the options for the PromQL engine to ensure that
PromQL metrics are registered following the change in
prometheus/prometheus@f8fccc7. The options used here are copied
from the defaults.
Prometheus vendors its own dependencies but also provides library
packages, meaning that we have to manage its dependencies as transient
dependencies. Using the
deptool, we cannot manage transientdependencies using regular constraints so I had to pin the versions in
Gopkg.tomlusing overrides.See:
https://github.com/golang/dep/blob/master/docs/FAQ.md#how-do-i-constrain-a-transitive-dependencys-version
golang/dep#999 (comment)
golang/dep#302