Use "..." instead of ellipsis on UTF-8 failure. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh for the life of me I cannot get the test working on Windows. I'll come back to this later! 😠 |
|
Yes this does look good. I think ideally, it would strip off 2 more chars from the end of the line in ASCII mode. When I tried substituting the 3 periods, it caused the lines to wrap with the last 2 periods on the following line. But looking at your test, it seems like it somehow does this already since it asserts that the total length including the 3 periods is 11 (10 chars + the newline). I can't understand how this works, but it seems to do the right thing! Good luck with windowz. |
This can happen when SSHKit returns stdout/stderr data in raw ASCII-8BIT form.
mattbrictson
force-pushed
the
ascii-truncation
branch
from
72bff32
to
3dc16bd
Compare
|
@robd Thanks for reviewing! I think I finally have the Windows issue fixed. |
mattbrictson
added a commit
that referenced
this pull request
Jul 22, 2015
Use "..." instead of ellipsis on UTF-8 failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when SSHKit returns stdout/stderr data in raw ASCII-8BIT form.
@robd Does this look like a good fix for #57?