Update tests to work with sshkit master / unknown user #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I like that this also simplifies the test setup somewhat. I'll merge once CI is complete. |
|
Yes, I'm no fan of stubs if they can be avoided. Maybe there should be an explicit tests for the "user@host" vs "host" formatting? |
|
The appveyor tests now run into sshkit's windows incompatibility before the changes to master, so maybe we need to keep the Etc stub for that? The new sshkit version should be out soon, at which point the appveyor tests would work. |
|
Yes, you're right. Unfortunately I think the |
This accounts for changes in sshkit's local username lookup introduced by capistrano/sshkit#293 and also accounts for the conditional formatting changes introduced by mattbrictson#66. The latter did not previously cause failed tests, because the username was stubbed in the tests, causing the relevant code to not be exercised. Now the username is looked up through sshkit, which results in an empty username on sshkit < 1.7.0, so the no-username display is triggered. Unfortunately we need to keep the Etc stub for now to avoid crashing on Windows with sshkit 1.7.0 and 1.7.1.
felixbuenemann
force-pushed
the
fix-tests-for-sshkit-master
branch
from
5acfdd7
to
a633f64
Compare
|
OK, I've added back the Etc stub for sshkit <= 1.7.1. |
|
Thanks! |
mattbrictson
added a commit
that referenced
this pull request
Nov 1, 2015
Update tests to work with sshkit master / unknown user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accounts for changes in sshkit's local username lookup introduced by capistrano/sshkit#293 and also accounts for the conditional formatting changes introduced by #66.
The latter did not previously cause failed tests, because the username was stubbed in the tests, causing the relevant code to not be exercised.
Now the username is looked up through sshkit, which results in an empty username on sshkit < 1.7.0, so the no-username display is triggered ("on host" vs. "as foo@host").