Skip building vite assets in tests if possible #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
added
✨ Feature
mattbrictson
changed the title
mattbrictson
changed the title
This speeds up running e.g. unit tests where compiling assets is not needed.
mattbrictson
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the presence of
vite.rbintest/support/meant that Vite assets would be eagerly built whenever any type of test was run. When running a model test, for example, this would lead to unnecessarily slow test startup time.What we want is to compile Vite assets before system tests, and before helper tests that specifically expect compiled assets.
Implement this by moving the Vite compilation logic to
test/vite_helper.rb. Tests can now explicitlyrequire "vite_helper"if they require compiled assets.Add
require "vite_helper"toapplication_system_test_case.rbso that system tests always have compiled assets.